-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build system: add netif_openwsn feature #20695
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
requested review from
leandrolanzieri,
aabadie,
MichelRottleuthner,
benpicco and
dylad
as code owners
May 24, 2024 20:56
github-actions
bot
added
Platform: native
Platform: This PR/issue effects the native platform
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Area: network
Area: Networking
Area: tests
Area: tests and testing framework
Area: build system
Area: Build system
Area: pkg
Area: External package ports
Area: boards
Area: Board ports
Area: cpu
Area: CPU/MCU ports
labels
May 24, 2024
maribu
added
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
State: waiting for other PR
State: The PR requires another PR to be merged first
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
Platform: native
Platform: This PR/issue effects the native platform
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Area: network
Area: Networking
Area: tests
Area: tests and testing framework
Area: pkg
Area: External package ports
Area: boards
Area: Board ports
Area: cpu
Area: CPU/MCU ports
labels
May 24, 2024
mguetschow
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reasoning and code changes look good to me!
maribu
force-pushed
the
pkg/openwsn/feature
branch
from
May 27, 2024 13:40
e559bc3
to
a697b01
Compare
maribu
removed
the
State: waiting for other PR
State: The PR requires another PR to be merged first
label
May 27, 2024
github-actions
bot
added
the
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
label
May 27, 2024
github-actions
bot
added
Area: network
Area: Networking
Area: tests
Area: tests and testing framework
Area: pkg
Area: External package ports
Area: boards
Area: Board ports
Area: cpu
Area: CPU/MCU ports
labels
May 27, 2024
maribu
added
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
May 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 27, 2024
Boards / MCUs now provide the newly introduced netif_openwsn feature if they have a network interface supported by OpenWSN.
OpenWSN requires a compatible network interface (feature `netif_openwsn`) and UART (at least `UART_NUMOF` needs to be provided).
`UART_NUMOF` is defined in `periph_conf.h`, not in `board.h`.
Now that OpenWSN depends on netif_openwsn, there is no need for manually tracking which boards are supported
maribu
force-pushed
the
pkg/openwsn/feature
branch
from
May 27, 2024 20:57
a697b01
to
61679fb
Compare
maribu
added
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
May 28, 2024
Thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: boards
Area: Board ports
Area: build system
Area: Build system
Area: cpu
Area: CPU/MCU ports
Area: network
Area: Networking
Area: pkg
Area: External package ports
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Boards / MCUs now provide the newly introduced
netif_openwsn
feature if they have a network interface supported by OpenWSN. The package now depends on this feature.With that in place, the white lists of boards supporting OpenWSN in the OpenWSN test apps can now be dropped (and in fact, are dropped).
Testing procedure
The CI should build the OpenWSN test apps for all boards it did before, plus more compatible. The diff of
make info-boards-supported
is:(Hence, no board for them whitelist is gone, but new boards became supported.)
The CI will test if indeed all those boards are compatible.
Issues/PRs references
Contains the last fix for #20680